fix: correct the formula for interpolating between bin start and end (interpolatedSignalRef) #9111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new formula correctly makes bandPosition = 0 represent start and bandPosition = 1 represents end.
(The existing code wasn't consistent with the simplified formula when bandPosition = 0 or 1
```
if (bandPosition === 0 || bandPosition === 1) {
ref.scale = scaleName;
const field = bandPosition === 0 ? start : end;
ref.field = field;
}
```
|
Code looks good but I'd encourage checking to make sure this doesn't result in any stale documentation. Alternatively if this is now an invariant, maybe we should be documenting it? |
kanitw
force-pushed
the
kw/fix-interpolatedSignalRef
branch
from
2f193b6
to
5ed6d05
Compare
kanitw
changed the title
|
Btw, after checking more, I can confirm that the resulting diff is correct. (The formula was indeed wrong. One example is that in the old code, band=0.99 is wider than band=1, simply because the offset to add 1 pixel is applied in the wrong direction due to the wrong formula. Before
After
Thus, the diff that makes the bar narrower is similarly correct 
|
lsh
approved these changes
Sep 29, 2023
kanitw
changed the title
alliefeldman
pushed a commit
to alliefeldman/vega-lite
that referenced
this pull request
Oct 10, 2023
…(interpolatedSignalRef) (vega#9111) Co-authored-by: GitHub Actions Bot <[email protected]>
BradyJ27
pushed a commit
to BradyJ27/vega-lite
that referenced
this pull request
Oct 19, 2023
…(interpolatedSignalRef) (vega#9111) Co-authored-by: GitHub Actions Bot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new formula correctly makes bandPosition = 0 represent start and bandPosition = 1 represents end.
(The existing code wasn't consistent with the simplified formula when bandPosition = 0 or 1)